-
Notifications
You must be signed in to change notification settings - Fork 78
fix(data): use hint for pause instruction
#1210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
tsk, tsk. CI found trailing whitespace. :-) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replace `pseudoinstructions` inline in `fence.yaml` with hint references
Oops. Fixed. Seems like the ISS is failing now. I'll look into it later. |
|
@henrikg-qc, ISS is getting an undefined value error. It's not obvious to me from the diff why. |
|
I was looking into this more locally, and so far I haven't found anything useful. The backtrace doesn't go back past the ruby, so it's hard to track down what is going wrong. |
|
The problem appears to stem from the unknown value of menvcfg.FIOM field, which the ISS conveniently detects. In this particular case, however, those bits are not relevant to the failing test. Suggested resolution is to create a new parameter for the reset value of FIOM, and set that parameter in the config file for riscv-tests. Jordan said he'd try this when he got time. |
Replace
pseudoinstructionsinline infence.yamlwith hint references.Fixes #1181